fix(config): qualify native Ollama exports after onboarding - #11550
Merged
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (15)
Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review. 📝 WalkthroughWalkthroughThe change adds nullable OpenAI profile handling, Ollama credential validation, shared configuration-export test utilities, attached Ollama export coverage, and revised GPU E2E daemon readiness and cleanup. ChangesOllama export qualification
Priority: ➖ Normal Estimated code review effort: 4 (Complex) | ~60 minutes Change: Bug fix Sequence Diagram(s)sequenceDiagram
participant GPU E2E test
participant Attached Ollama
participant Readiness helper
participant Managed proxy
GPU E2E test->>Attached Ollama: Start daemon after onboarding
GPU E2E test->>Readiness helper: Poll /api/tags
Readiness helper-->>GPU E2E test: Return readiness result
GPU E2E test->>Attached Ollama: Pull configured model
GPU E2E test->>Managed proxy: Export configuration
Managed proxy-->>GPU E2E test: Return provider configuration and evidence
Possibly related PRs
Suggested reviewers: Merge Risk: ⚪ Minimal · up to No actionable merge-blocking issue is identified. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 4.76% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 21 functions across 12 files. (3 skipped: 3 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
Contributor
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall line coverage in commit c9e6185 in the TypeScript / code-coverage/cliThe overall line coverage in commit c9e6185 in the Show a line coverage summary of the most impacted files.
Updated |
sandl99
changed the title
Signed-off-by: San Dang <sdang@nvidia.com>
Signed-off-by: San Dang <sdang@nvidia.com>
Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>
sandl99
changed the title
Signed-off-by: San Dang <sdang@nvidia.com>
sandl99
changed the title
Signed-off-by: San Dang <sdang@nvidia.com>
Signed-off-by: San Dang <sdang@nvidia.com>
Signed-off-by: San Dang <sdang@nvidia.com>
Contributor
|
PR Review Advisor finished for commit |
prekshivyas
marked this pull request as ready for review
September 14, 2026 06:29
prekshivyas
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Native Linux Docker OpenClaw configuration export works with an attached Ollama daemon and refuses publication after that daemon stops. The GPU qualification passes alongside both existing inference scenarios.
Reason
Normal onboarding registers an internal proxy credential and an OpenAI provider type without a profile in its bound workspace. Export rejected those valid states. The E2E fixture also treated transient readiness timeouts as terminal, stopped its daemon before dependent cleanup, and rejected an internal hostname in the correctly preserved network policy.
Related issues
Refs #11435. Repairs export qualification introduced by #11473.
Changes
Verification
Tested commit:
c9e6185488b3fc05bb0b125ca2f42280bd9cb555.10335275785.Review notes
Advisor completed all nine specialists for the tested commit: eight clear; one inherited timeout finding,
F-delivery-flow-3fae8283e608b84d83d7.Disposition: the recorded base already contains all three scenarios and their 75/90/75-minute limits. Its GPU job limit is already 90 minutes. This PR preserves those limits and reduces export setup from a 55-minute allowance to two 20-minute allowances. The finding is inherited and requires no change in this repair. The passing run does not eliminate that existing worst-case timeout risk.
Complete feedback collection found four comments, no reviews, and no review threads. CodeRabbit skipped the draft. No unresolved candidate-owned finding remains.
Self-review of NVIDIA/NemoClaw at the tested commit covered provider qualification, stable export evidence, proxy credential custody, the E2E lifecycle, and the owning inference/adapter guides against the shared security rubric. Export remains read-only and requires the authenticated proxy, daemon model, and managed OpenClaw route to agree. No approval or waiver is claimed. The PR remains draft.
Signed-off-by: San Dang sdang@nvidia.com
Signed-off-by: Julie Yaunches jyaunches@nvidia.com
Summary by CodeRabbit
New Features
Bug Fixes
Documentation